Memory leak with previous adjustment brush history

Status
Not open for further replies.
Joined
Oct 23, 2007
Messages
680
Location
Perth, Australia
I have noticed since 3.2 the memory leaks when using the adjustment brush, but it has been tolerable until the last week or so. I have found a specific behavior in the Develop module that makes LR unusable.

Scrolling through images and making minor changes i discovered what appears as a serious memory leak.

1. Image with NO history of adjustment brush develop changes - normal.
2. Image with a history of adjustment brush develop changes - LR grinds to a halt and the dreaded "LR is not responding" appears to the point i have to force close LR.

This is repeatable with every image in my entire catalogue that has a adjustment brush develop change.lrcat optimized 3 days ago. No other applications open on the PC. Adjustment brush closed. Attaches is an example of what happens when i change from one image to another, dependent on the develop history.
 
Last edited:
Joined
Jun 24, 2010
Messages
1,689
Location
Encinitas, CA USA
Lightroom Experience
Advanced
Lightroom Version
Classic
Hi Brad,

I mean the JPEG preview that is optionally stored in the DNG file not the LR previews which are stored separately. I am not quite where to control this option since I stopped using DNG a year ago when I moved from Bridge/ACR to Lightroom 3.

There is an option in the "File Handling" tab of the LR Preferences where you can select the JPEG preview size for import (none, medium, full). I don't know if that will also control the how existing DNG files in you library are handled or if there is another setting somewhere that controls the behavior.

-louie
 
Joined
Jun 24, 2010
Messages
1,689
Location
Encinitas, CA USA
Lightroom Experience
Advanced
Lightroom Version
Classic
Good morning Geoff,

In ACR preferences there is an option to enable/disable "Update embedded JPEG preview". Your are correct, this does not appear anywhere in LR that I can find either. This enabling this option in ACR clearly has the effect of updating the embedded preview with the latest develop settings. This is what was killing performance when I was using Rapid Fixer in Bridge. It was ACR to rewrite the whole DNG file for every click. Needless to say it was rather slow. This was quit similar to what Brad was describing which is what got my attention.

I just reread the section "Import DNG Creation" in Martin Evenings, LR3 book (pp. 606-609) and came away with the clear understanding the LR will or won't, update or not update the preview when it you make an edit after importing and an initial preview is generated. Yes it was clear as mud.

Maybe John Beardsworth can shed more light on the subject.

-louie
 
Joined
Oct 23, 2007
Messages
680
Location
Perth, Australia
Good morning Geoff,

In ACR preferences there is an option to enable/disable "Update embedded JPEG preview". Your are correct, this does not appear anywhere in LR that I can find either. This enabling this option in ACR clearly has the effect of updating the embedded preview with the latest develop settings. This is what was killing performance when I was using Rapid Fixer in Bridge. It was ACR to rewrite the whole DNG file for every click. Needless to say it was rather slow. This was quit similar to what Brad was describing which is what got my attention.

I just reread the section "Import DNG Creation" in Martin Evenings, LR3 book (pp. 606-609) and came away with the clear understanding the LR will or won't, update or not update the preview when it you make an edit after importing and an initial preview is generated. Yes it was clear as mud.

Maybe John Beardsworth can shed more light on the subject.

-louie

LR must render the preview you are view in the develop module on the fly, as you make changes. IN ACR, how can one see the changes made if you disable "Update embedded JPEG preview"? Mud....

I am wondering whether there is a problem with the DNG specification. Writting data to a CR2 with an xmp file is just that, data. But, given the xmp is embedded in the DNG, i wonder whether the 'whole' DNG has to re-written with any metadata changes.
 
Joined
Jun 24, 2010
Messages
1,689
Location
Encinitas, CA USA
Lightroom Experience
Advanced
Lightroom Version
Classic
LR must render the preview you are view in the develop module on the fly, as you make changes. IN ACR, how can one see the changes made if you disable "Update embedded JPEG preview"?

Everything is rendered to your screen in ACR as you work. This also stored in the ACR cache so when open again in ACR you can see the latest rendered version on you monitor almost immediately. LR shares the same ACR cache.

The imbedded preview is primarily there for other applications (read not ACR or LR) that cannot render the raw file with the saved settings. A lot of photographers are using Expression Media (used to be iView now is Media Pro) catalog application. Having the imbedded JPEG is the only way it can display your "developed" version of the image.

I am wondering whether there is a problem with the DNG specification. Writting data to a CR2 with an xmp file is just that, data. But, given the xmp is embedded in the DNG, i wonder whether the 'whole' DNG has to re-written with any metadata changes.

The answer is yes. If you turn this on the DNG file is rewritten every time you make a change to any metadata. That would be IPTC fields or changes to the develop settings. It's not a design flaw but a feature intended to do away with the need for a separate .xmp sidecar file. It makes it easier to send the raw image off in a single file that includes all your relevant metadata. But it also has this side effect. Most people who use DNG files leave the update option turned off for this reason and only update from the menu if they send the file off out side of LR.

-louie
 
Status
Not open for further replies.
Top